Boolean in select #4141
Merged
Boolean in select #4141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
force-pushed
the
booleanInSelect
branch
3 times, most recently
from
4848708 to
2d7604e
Compare
smitpatel
force-pushed
the
booleanInSelect
branch
from
2d7604e to
176ae22
Compare
| @@ -143,7 +143,14 @@ public virtual Expression VisitSelect(SelectExpression selectExpression) | |||
| _relationalCommandBuilder.Append(", "); | |||
| } | |||
|
|
|||
| VisitJoin(selectExpression.Projection); | |||
| var comparisonTransformer = new ProjectionComparisonTransformingVisitor(); | |||
| var nullComparisonTransformer = new NullComparisonTransformingVisitor(_parametersValues); | |||
There was a problem hiding this comment.
DRY this up with predicate case below.
smitpatel
force-pushed
the
booleanInSelect
branch
3 times, most recently
from
5234fd1 to
c1fa3a3
Compare
|
Updated |
|
@smitpatel Does this potentially resolve #649? |
| @@ -1125,7 +1132,7 @@ protected virtual bool TryGenerateBinaryOperator(ExpressionType op, [NotNull] ou | |||
| protected override Exception CreateUnhandledItemException<T>(T unhandledItem, string visitMethod) | |||
| => new NotImplementedException(visitMethod); | |||
|
|
|||
| private class NullComparisonTransformingVisitor : RelinqExpressionVisitor | |||
| protected class NullComparisonTransformingVisitor : RelinqExpressionVisitor | |||
smitpatel
force-pushed
the
booleanInSelect
branch
from
c1fa3a3 to
506be17
Compare
|
#649 is resolved by this at least for projections. Added test for it. |
|
|
smitpatel
force-pushed
the
booleanInSelect
branch
from
506be17 to
2837445
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3703
Issue: SQL does not allow not operation on Boolean type directly. They must be compared with true or false. Fix is to convert unary operations on Boolean type to comparison operation.
resolves #3618
Issue: SQL does not allow comparison operation into projection. They must be wrapped in
Case When Thenblock.Fix: Whenever there is comparison operation into projection, convert it to conditional expression.
If comparison operation is inside conditional expression already then do no convert.
Issue: Comparison follows null semantics.
Implementation: While processing
SelectExpressionprocess the projection accordingly.resolves #649 for projections