Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tiny] Block shadow keys created by convention #4015

Merged
merged 1 commit into from
Dec 9, 2015
Merged

[Tiny] Block shadow keys created by convention #4015

merged 1 commit into from
Dec 9, 2015

Conversation

smitpatel
Copy link
Contributor

Resolves #3978
We had check in place, it just wasn't running. 😄

@AndriySvyryd
Copy link
Member

We also have ModelValidator.EnsureNoShadowKeys. Why isn't that throwing?

@AndriySvyryd
Copy link
Member

:shipit:

@smitpatel
Copy link
Contributor Author

filed #4016

@smitpatel smitpatel force-pushed the blockConventionalShadowKey branch from 3e6b6ad to 2d79bc5 Compare December 9, 2015 19:04
@smitpatel smitpatel merged commit 2d79bc5 into dev Dec 9, 2015
@smitpatel smitpatel deleted the blockConventionalShadowKey branch December 9, 2015 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smitpatel @AndriySvyryd @dnfclas