Implement right join support #35462
Open
Implement right join support #35462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
force-pushed
the
RightJoin
branch
2 times, most recently
from
4cb34bb to
778c04e
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
SamMonoRT
reviewed
Jan 28, 2025
| @@ -620,6 +620,31 @@ FROM [JsonEntitiesSingleOwned] AS [j] | |||
| """); | |||
| } | |||
|
|
|||
| public override async Task RightJoin_json_entities(bool async) | |||
| { | |||
| // TODO:SQLJSON Returns empty (invalid) JSON (See BadJson.cs) | |||
There was a problem hiding this comment.
this should not block a PR merge. we can create an issue to track this work later.
|
LGTM - @cincuranet please take a look |
SamMonoRT
approved these changes
Jan 28, 2025
cincuranet
reviewed
Jan 29, 2025
| private static ConstructorInfo? _quotingConstructor; | ||
|
|
||
| /// <summary> | ||
| /// Creates a new instance of the <see cref="LeftJoinExpression" /> class. |
There was a problem hiding this comment.
Suggested change
| /// Creates a new instance of the <see cref="LeftJoinExpression" /> class. | |
| /// Creates a new instance of the <see cref="RightJoinExpression" /> class. |
| /// <summary> | ||
| /// Creates a new instance of the <see cref="LeftJoinExpression" /> class. | ||
| /// </summary> | ||
| /// <param name="table">A table source to LEFT JOIN with.</param> |
There was a problem hiding this comment.
Suggested change
| /// <param name="table">A table source to LEFT JOIN with.</param> | |
| /// <param name="table">A table source to RIGHT JOIN with.</param> |
cincuranet
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on top of #35451, review from 2nd commit only.Closes #35367