[release/9.0] Fix conditional test evaluation in funcletizer #34886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add a backport PR |
AndriySvyryd
changed the title
This is already targeting 9.0, I updated the title |
AndriySvyryd
approved these changes
Oct 11, 2024
|
Approved via email |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34883
Description
EF's funcletizer (first and very important step in the query pipeline) was rewritten in EF 9, both to allow query precompilation (NativeAOT) and for better performance (see #33106). The new implementation contains a bug in the conditional expression handling when the test component of the conditional expression is client-evaluatable.
Customer impact
Queries that contain the conditional operator with a client-evaluatable test (e.g.
foo() ? x : ysometimes fail to execute.How found
Customer reported on 9.0.0-rc1
Regression
Yes, from 8.
Testing
Test added.
Risk
Low