[release/6.0] Stop storing model references in the EntityMaterializerSource #31943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Source Fixes #31866 This is the second part of the memory leak fix from #31867 ### Description Storing references to the model resulted in a customer reported memory leak in multi-tenant application. ### Customer impact Customer-reported large memory leak. ### How found Customer reported. ### Regression No. ### Testing Existing tests cover that there is no regression with the change in cache location. Manual testing that the model is no longer referenced. ### Risk Low. Also quirked.
AndriySvyryd
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31866
This is the second part of the memory leak fix from #31867
Description
Storing references to the model resulted in a customer reported memory leak in multi-tenant application.
Customer impact
Customer-reported large memory leak.
How found
Customer reported.
Regression
No.
Testing
Existing tests cover that there is no regression with the change in cache location. Manual testing that the model is no longer referenced.
Risk
Low. Also quirked.