-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #27138, stream with 64-bit PK #27187
Conversation
@bricelam a couple of the CI jobs are failing, but it looks to be an issue with the CosmosDB emulator in the pipeline, AFAICS. |
The CI has been a bit flakey. The test passed on Linux, Windows, and macOS, so I'm comfortable merging it. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I am not comfortable merging on failing CI at least unless it fails on multiple attempts. We broke main branch with SqlClient upgrade by ignoring CI failure. |
d6d8587
to
71da8fe
Compare
Rebased on main. Updated the test to cover |
Hello @bricelam! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
It looks like it has failed the same way on 2 attempts - I think @ajcvickers manually kicked on the 2nd rerun. |
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
CI seems to be succeeding today. I bet the rebase will let it pass this time. |
Wow msftbot, have you been hanging around Marvin or something? |
@cocowalla Thank you for your contribution! It should be available in the daily builds soon, and in 7.0 Preview 1 whenever that ships (probably February). |
Resolves an issue with blob streaming, where a 32-bit PK was always expected - but SQLite stores integers as signed, 64-bit values.
GetInt32
toGetInt64
Fixes #27138