Commits on Dec 8, 2021

1. Query: Defer inline-ing owned navigation expansion till all joins are… …

   … generated
   
   Issue: Expanding owned navigations in relational falls into 3 categories
   - Collection navigation - which always generates a subquery. The predicate is generated in LINQ to allow mutation of outer SelectExpression
   - Reference navigation sharing table - which picks column from same table without needing to add additional join. This only mutate the projection list for SelectExpression at subquery level
   - Reference navigation mapped to separate table - which generates additional joins. Generating join can cause push down on outer SelectExpression if it has facets (e.g. limit/offset). This pushdown causes owned expansion from category 2 to be outdated and invalid SQL since they get pushed down to subquery. While their relevant entity projection is updated inside SelectExpression we already inlined older object in the tree at this point.
   
   In order to avoid issue with outdated owned expansion, we defer actual inline-ing while processing owned navigations so that all navigations are expanded (causing any mutation on SelectExpression) before we inline values.
   
   This PR introduces DeferredOwnedExpansionExpression which remembers the source projection binding to SelectExpression (which will remain accurate through pushdown), and navigation chain to traverse entity projections to reach entity shaper for final owned navigation. This way, we get up-to-date information from SelectExpression after all joins are generated.
   We also find updated entity projection through binding after we generate a join if pushdown was required.
   
   Resolves #26592
   
   The issue was also present in 5.0 release causing non-performant SQL rather than invalid SQL. During 5.0 we expanded owned navigations again while during client eval phase (which happens in customer scenario due to include). This caused to earlier owned reference to have correct columns. Though the entity projection for owner was changed due to pushdown so we didn't add latter reference navigation binding in correct entity projection causing us to expand it again during 2nd pass.
   
   The exact same issue doesn't occur for InMemory provider (due to slightly different implementation) though we should also make InMemory provider work this way, which we can do in 7.0.

   

   smitpatel committed Dec 8, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 065699a
   • Browse repository at this point

   Copy the full SHA

   065699a View commit details

   Browse the repository at this point in the history