Cosmos: Set ValueGenerated.Never for most integer properties #26152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Pilchie For approval |
AndriySvyryd
changed the title
ajcvickers
reviewed
Sep 23, 2021
ajcvickers
approved these changes
Sep 23, 2021
|
Approved for EFCore 6.0 |
AndriySvyryd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25167
Description
Cosmos doesn't support value generation, however integer properties were marked as
ValueGenerated.OnAdd. OnlyGuidproperties and the non-persistedintordinals for embedded collections are generated on the client.Customer impact
Attaching an entity with an integer key will mark it as Updated instead of Added resulting in an error on the next
SaveChangesHow found
Customer
Regression
No
Testing
Test for this scenario added in the PR.
Risk
Low, only affects scenarios with value generation, which are not supported in Cosmos.