Fix to #26014 - Migrations/Temporal Tables: null value exception when executing Down migration to convert entity from temporal to normal #26053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… executing Down migration to convert entity from temporal to normal Problem was that we perform a null check on old and new annotation, but null is a valid value for annotation. We should allow this and also mark the annotation value as nullable object. Also fixed small issue in code gen where we would not generate code to add annotation with null value (but we were adding it for old annotation). Fixes #26014
AndriySvyryd
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem was that we perform a null check on old and new annotation, but null is a valid value for annotation. We should allow this and also mark the annotation value as nullable object. Also fixed small issue in code gen where we would not generate code to add annotation with null value (but we were adding it for old annotation).
Fixes #26014