Migrations: Honor [Column(Order)] in CreateTable operation #25942
Conversation
|
Since SQLite does a table rebuild for any AlterColumn operation, we end up doing a full rebuild if you change the explicit order of a column, so that actually works on SQLite. 😁 |
|
Hello @bricelam! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
|
Apologies, while this PR appears ready to be merged, it looks like |
| if (operation[RelationalAnnotationNames.ColumnOrder] != operation.OldColumn[RelationalAnnotationNames.ColumnOrder]) | ||
| { | ||
| Dependencies.MigrationsLogger.ColumnOrderIgnoredWarning(operation); | ||
| } |
There was a problem hiding this comment.
Providers, you may also want to add this code to your AlterColumn code. (and AddColumn if you don't call base)
Resolves #10059