[release/6.0-rc1] Remove unused nullability in typeof #25664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Causes compilation error starting with dotnet SDK 6.0.100-rc.1.21417.19
roji
force-pushed
the
roji/TinyNullabilityThing
branch
from
a26d135 to
a3869de
Compare
|
Note: I rebased this on 6.0-rc1, since the error occurs with an rc1 SDK. |
|
@roji I suspect I was invited to this PR when you changed the target branch. But, I don't have context… |
|
@dougbu starting with SDK 6.0.100-rc.1.21417.19, the line I changed no longer compiles, because of dotnet/roslyn#54956. This PR doesn't do any actual change: |
ajcvickers
changed the title
ajcvickers
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes compilation errors starting with .NET SDK 6.0.100-rc.1.21417.19
Customer Impact
We won't be able to build the product to ship to them.
How found
Updating the SDK.
Test coverage
Compile-time issue.
Regression?
N/A
Risk
Low. Makes the compiler work.
Flagged by @sebastienros because of failures in continuous benchmark runs