Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SMALL] Enabling some Distinct tests on Cosmos #25505

Merged
merged 1 commit into from
Aug 13, 2021
Merged

[SMALL] Enabling some Distinct tests on Cosmos #25505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 13 additions & 16 deletions test/EFCore.Cosmos.FunctionalTests/Query/NorthwindAggregateOperatorsQueryCosmosTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Linq;
using System.Runtime.CompilerServices;
using System.Threading.Tasks;
using Microsoft.EntityFrameworkCore.TestModels.Northwind;
using Microsoft.EntityFrameworkCore.TestUtilities;
using Xunit;
Expand Down Expand Up @@ -772,41 +769,41 @@ FROM root c
WHERE (c[""Discriminator""] = ""Employee"")");
}

[ConditionalTheory(Skip = "Issue#16144")]
[ConditionalTheory]
public override async Task Distinct(bool async)
{
await base.Distinct(async);

AssertSql(
@"SELECT c
@"SELECT DISTINCT c
FROM root c
WHERE (c[""Discriminator""] = ""Customer"")");
}

[ConditionalTheory(Skip = "Issue#16144")]
[ConditionalTheory]
public override async Task Distinct_Scalar(bool async)
{
await base.Distinct_Scalar(async);

AssertSql(
@"SELECT c
@"SELECT DISTINCT c[""City""]
FROM root c
WHERE (c[""Discriminator""] = ""Customer"")");
}

[ConditionalTheory(Skip = "Issue#16144")]
[ConditionalTheory]
public override async Task OrderBy_Distinct(bool async)
{
await base.OrderBy_Distinct(async);

// Ordering not preserved by distinct when ordering columns not projected.
AssertSql(
@"SELECT c
@"SELECT DISTINCT c[""City""]
FROM root c
WHERE (c[""Discriminator""] = ""Customer"")");
WHERE (c[""Discriminator""] = ""Customer"")
ORDER BY c[""CustomerID""]");
}

[ConditionalTheory(Skip = "Issue#16144")]
[ConditionalTheory(Skip = "Issue#16156")]
public override async Task Distinct_OrderBy(bool async)
{
await base.Distinct_OrderBy(async);
Expand All @@ -817,7 +814,7 @@ FROM root c
WHERE (c[""Discriminator""] = ""Customer"")");
}

[ConditionalTheory(Skip = "Issue#16144")]
[ConditionalTheory(Skip = "Issue#16156")]
public override async Task Distinct_OrderBy2(bool async)
{
await base.Distinct_OrderBy2(async);
Expand All @@ -828,7 +825,7 @@ FROM root c
WHERE (c[""Discriminator""] = ""Customer"")");
}

[ConditionalTheory(Skip = "Issue#16144")]
[ConditionalTheory(Skip = "Issue#16156")]
public override async Task Distinct_OrderBy3(bool async)
{
await base.Distinct_OrderBy3(async);
Expand All @@ -839,7 +836,7 @@ FROM root c
WHERE (c[""Discriminator""] = ""Customer"")");
}

[ConditionalTheory(Skip = "Issue#16144")]
[ConditionalTheory(Skip = "Issue#16156")]
public override async Task Distinct_Count(bool async)
{
await base.Distinct_Count(async);
Expand All @@ -850,7 +847,7 @@ FROM root c
WHERE (c[""Discriminator""] = ""Customer"")");
}

[ConditionalTheory(Skip = "Issue#16144")]
[ConditionalTheory(Skip = "Issue#16156")]
public override async Task Select_Select_Distinct_Count(bool async)
{
await base.Select_Select_Distinct_Count(async);
Expand Down