Enable value conversion support for identity/sequence properties #25178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to use value converters for identity and sequence columns, within the limitations already established (must be a non-floating point numerical type on the provider side).
Implements PomeloFoundation/Pomelo.EntityFrameworkCore.MySql#1118 for SQL Server.
I added an explicit
.UnwrapNullableType()
call, so that adecimal?
would behave the same way as anint?
(both are not really supported for identity columns by SQL Server, but they should at least be handled in the same way before SQL Server finally returns an error, and should not lead to different behavior in EF Core).It would probably be cleaner to check for non-nullable types only in general instead.
Related to #11597 and npgsql/efcore.pg#1439
I don't see any issues with this PR in regards to #11597.
If there are, feel free to add a test or two to demonstrate those.