Delay synthesis of join entities until entire graph is attached #24572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
reviewed
Apr 2, 2021
AndriySvyryd
reviewed
Apr 2, 2021
AndriySvyryd
approved these changes
Apr 2, 2021
ajcvickers
force-pushed
the
TomsDiner0401
branch
from
bcd02b9
to
9c25ab3
Compare
AndriySvyryd
reviewed
Apr 3, 2021
| @@ -47,27 +47,36 @@ public class EntityGraphAttacher : IEntityGraphAttacher | |||
| EntityState targetState, | |||
| EntityState storeGeneratedWithKeySetTargetState, | |||
| bool forceStateWhenUnknownKey) | |||
| => _graphIterator.TraverseGraph( | |||
| { | |||
| rootEntry.StateManager.ResetAttachGraph(); | |||
There was a problem hiding this comment.
If there are any danglers at this point why would we discard them?
Also shouldn't we also call CompleteAttachGraph on DetectChanges?
There was a problem hiding this comment.
@AndriySvyryd I thought some more about where danglers can come from and added additional test cases. This lead to a change where I made it more explicit that this is a Begin/End behavior.
Fixes #23339 This stops the change tracker creating a join entity instance for the same join entity that is later discovered in the graph.
ajcvickers
force-pushed
the
TomsDiner0401
branch
from
9c25ab3
to
6a51cbe
Compare
AndriySvyryd
approved these changes
Apr 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23339
This stops the change tracker creating a join entity instance for the same join entity that is later discovered in the graph.