Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .NET SDK to 6.0.100-preview.2.21155.3 #24405

Merged
2 commits merged into from
Mar 15, 2021
Merged

Update .NET SDK to 6.0.100-preview.2.21155.3 #24405

2 commits merged into from
Mar 15, 2021

Conversation

bricelam
Copy link
Contributor

No description provided.

@bricelam bricelam requested a review from a team March 15, 2021 21:15
Comment on lines +14 to 16
"version": "6.0.100-preview.2.21155.3",
"allowPrerelease": true,
"rollForward": "latestMajor"
Copy link
Contributor Author

@bricelam bricelam Mar 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, contributors will need to install this version if they don't use startvs.cmd

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add this to https://github.com/dotnet/efcore/blob/main/docs/getting-and-building-the-code.md? (assuming installing this SDK and opening VS just works, earlier it didn't)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it's preview SDKs (as opposed to dailies), that seems pretty reasonable to me... Yeah, a note in in the building docs seems appropriate...

<TargetFramework>net5.0</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
Copy link
Contributor Author

@bricelam bricelam Mar 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests and benchmarks updated to 6.0; product remains at 5.0 for now

@ghost
Copy link

ghost commented Mar 15, 2021

Hello @bricelam!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@bricelam
Copy link
Contributor Author

error NETSDK1148: Found multiple publish output files with the same relative path: test\EFCore.Design.Tests\xunit.runner.json, test\xunit.runner.json. [test\EFCore.Design.Tests\EFCore.Design.Tests.csproj]

@ghost ghost merged commit af2b6ef into dotnet:main Mar 15, 2021
@bricelam
Copy link
Contributor Author

Stupid bot. 😠

@bricelam bricelam deleted the net6.0 branch March 15, 2021 22:17
@smitpatel
Copy link
Contributor

ouch! The bots are taking over the world.

Seems like a new validation added in 6.0 dotnet/aspnetcore#29524
If removing xunit works then we can go with that. Or we can unblock using work-around from the thread.

@smitpatel
Copy link
Contributor

@bricelam
Copy link
Contributor Author

xunit.runner.json wasn't used anymore (it was left over from .NET Framework)

@bricelam
Copy link
Contributor Author

I'll keep an eye on the build to make sure it passes

@bricelam
Copy link
Contributor Author

cc @Pilchie This is the second time today the bot has merged my PR without waiting for CI. Happens immediately after a force-push with additional changes.

@smitpatel
Copy link
Contributor

I sent mail to bot team about this.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants