-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .NET SDK to 6.0.100-preview.2.21155.3 #24405
Conversation
"version": "6.0.100-preview.2.21155.3", | ||
"allowPrerelease": true, | ||
"rollForward": "latestMajor" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, contributors will need to install this version if they don't use startvs.cmd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add this to https://github.com/dotnet/efcore/blob/main/docs/getting-and-building-the-code.md? (assuming installing this SDK and opening VS just works, earlier it didn't)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as it's preview SDKs (as opposed to dailies), that seems pretty reasonable to me... Yeah, a note in in the building docs seems appropriate...
<TargetFramework>net5.0</TargetFramework> | ||
<TargetFramework>net6.0</TargetFramework> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests and benchmarks updated to 6.0; product remains at 5.0 for now
Hello @bricelam! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Stupid bot. 😠 |
ouch! The bots are taking over the world. Seems like a new validation added in 6.0 dotnet/aspnetcore#29524 |
xunit.runner.json wasn't used anymore (it was left over from .NET Framework) |
I'll keep an eye on the build to make sure it passes |
cc @Pilchie This is the second time today the bot has merged my PR without waiting for CI. Happens immediately after a force-push with additional changes. |
I sent mail to bot team about this. |
No description provided.