Fix to #23761 - UseRelationalNulls causes subquery to include NOT IN (NULL, x) #23856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Jan 12, 2021
src/EFCore.Relational/Query/RelationalQueryTranslationPostprocessor.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Jan 12, 2021
test/EFCore.Relational.Specification.Tests/Query/NullSemanticsQueryTestBase.cs
Show resolved
Hide resolved
smitpatel
reviewed
Jan 12, 2021
src/EFCore.Relational/Query/Internal/SqlExpressionSimplifyingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Jan 12, 2021
src/EFCore.Relational/Query/Internal/SqlExpressionSimplifyingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Jan 12, 2021
test/EFCore.Relational.Specification.Tests/Query/NullSemanticsQueryTestBase.cs
Show resolved
Hide resolved
maumar
force-pushed
the
fix23761
branch
2 times, most recently
from
16449ac to
54d35bc
Compare
smitpatel
approved these changes
Jan 14, 2021
…(NULL, x) We do optimization which combines comparisons based on the same property into IN and NOT IN. Problem is that if the comparisons contain nulls, we add those into the list of IN values, generating queries like a IN (1, 2, NULL). In normal circumstances, during null semantics processing we extract these nulls and produce correct IS NULL / IS NOT NULL calls, however when useRelationalNulls is enabled, we don't run null semantics visitor and therefore don't "fix" the IN expressions. Fix is to only apply the initial optimization for c# null semantics. Fixes #23761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do optimization which combines comparisons based on the same property into IN and NOT IN. Problem is that if the comparisons contain nulls, we add those into the list of IN values, generating queries like a IN (1, 2, NULL). In normal circumstances, during null semantics processing we extract these nulls and produce correct IS NULL / IS NOT NULL calls, however when useRelationalNulls is enabled, we don't run null semantics visitor and therefore don't "fix" the IN expressions.
Fix is to only apply the initial optimization for c# null semantics.
Fixes #23761