Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft.Data.Sqlite: Support GetSchema("ReservedWords") #23820

Merged
merged 2 commits into from
Jan 6, 2021
Merged

Microsoft.Data.Sqlite: Support GetSchema("ReservedWords") #23820

merged 2 commits into from
Jan 6, 2021

Conversation

bricelam
Copy link
Contributor

@bricelam bricelam commented Jan 5, 2021 •
edited
Loading

Part of aspnet/Microsoft.Data.Sqlite#443

Could also be used by #19599

cc @ericsink

@bricelam bricelam requested a review from a team January 5, 2021 20:06
@ericsink
Copy link

ericsink commented Jan 5, 2021

Just to make sure I'm not missing something: I'm tagged here because this merge will be waiting for my 2.0.5 release, right?

@bricelam
Copy link
Contributor Author

bricelam commented Jan 5, 2021

@ericsink lol, not really--you have 'til November. 😉 More just to let you know we're verifying the prerelease.

@ericsink
Copy link

ericsink commented Jan 5, 2021

:-)

Ah, yes. Thanks.

roji
roji approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When do we get all the rest of the schema collections 😉 IIRC that would be important for your new DDEX project!

test/Microsoft.Data.Sqlite.Tests/SqliteConnectionTest.cs Outdated Show resolved Hide resolved
test/Microsoft.Data.Sqlite.Tests/SqliteConnectionTest.cs Outdated Show resolved Hide resolved
test/Microsoft.Data.Sqlite.Tests/SqliteConnectionTest.cs Outdated Show resolved Hide resolved
@bricelam
Copy link
Contributor Author

bricelam commented Jan 5, 2021 •
edited
Loading

@roji I added them to the correct place in the DDEX provider where they can live happily as an implementation detail to an actual provider-agnostic API. 😉

@bricelam bricelam merged commit 8a14897 into dotnet:main Jan 6, 2021
@bricelam bricelam deleted the word branch January 6, 2021 22:08
@roji
Copy link
Member

roji commented Jan 6, 2021

I added them to the correct place in the DDEX provider where they can live happily as an implementation detail to an actual provider-agnostic API.

Maybe you can say a few words on that tomorrow, I'm interested in hearing your thoughts (we at least in theory have dotnet/runtime#28763 still open).

@ajcvickers ajcvickers mentioned this pull request Jan 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel left review comments

@roji roji roji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bricelam @ericsink @roji @smitpatel