[5.0.3] Fixes to database collation migrations #23809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Jan 5, 2021
|
Approved by Tactics for 5.0.3; please wait for the branch to open before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23794
Description
When generating migrations, if a database collation is configured and non was previously configured, a mangled migration is generated which does not compile.
Customer Impact
Any user trying to explicitly set a collation on an existing database will fail and would have to manually edit generated migration source code.
How found
Customer reported on 5.0.2.
Test coverage
We have added test coverage in this PR.
Regression?
No, collation support was only introduced in 5.0.
Risk
Low. Only affects the faulty code path, which is part of design-time migration generation (no runtime impact).