Microsoft.Data.Sqlite: Use multi-thread mode #23632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the default mode (usually Serialized) was used. Since ADO.NET connections are generally not thread safe, this caused unnecessary lock checking in SQLite. Resolves dotnet#22330
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the default mode (usually Serialized) was used. Since ADO.NET connections are generally not thread safe, this caused unnecessary lock checking in SQLite.
Note, this will break compatibility with versions compiled with SQLITE_THREADSAFE=0. However, we plan to add a connection pool in this release which, I suspect, will also break compatibility with those versions anyway.(Updated)Resolves #22330