Handle composite keys in SqliteDataReader.GetStream() #23590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricelam
commented
Dec 4, 2020
ajcvickers
approved these changes
Dec 17, 2020
bricelam
commented
Jan 5, 2021
| { | ||
| using (var command = _connection.CreateCommand()) | ||
| { | ||
| command.CommandText = "SELECT COUNT(*) FROM pragma_table_info($table) WHERE pk != 0;"; |
There was a problem hiding this comment.
We could avoid sending this if primaryKey != 1. But the chances of selecting only part of a composite key or not selecting the first component before the rest (which just happen to be an INTEGER) is so low that it'll probably never matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23554