Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for split include and no tracking #21218

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Add tests for split include and no tracking #21218

merged 1 commit into from
Jun 12, 2020

Conversation

smitpatel
Copy link
Contributor

Part of #20892

@smitpatel smitpatel requested a review from maumar June 11, 2020 09:32
@smitpatel smitpatel force-pushed the smit/splitincludes branch 2 times, most recently from 2ee5d88 to 6242987 Compare June 11, 2020 19:57
@smitpatel smitpatel force-pushed the smit/splitincludenotracking branch from 2c15b80 to e1fc65e Compare June 11, 2020 20:08
roji
roji approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments but otherwise LGTM

.../EFCore.Relational.Specification.Tests/Query/NorthwindSplitIncludeNoTrackingQueryTestBase.cs Outdated Show resolved Hide resolved
test/EFCore.Relational.Specification.Tests/Query/NorthwindSplitIncludeQueryTestBase.cs Show resolved Hide resolved
.../EFCore.Relational.Specification.Tests/Query/NorthwindSplitIncludeNoTrackingQueryTestBase.cs Show resolved Hide resolved
@smitpatel smitpatel force-pushed the smit/splitincludes branch 3 times, most recently from 60bbd5b to 1445d7b Compare June 12, 2020 01:47
Base automatically changed from smit/splitincludes to feature/splitInclude June 12, 2020 05:25
@smitpatel smitpatel force-pushed the smit/splitincludenotracking branch from e1fc65e to fa7f3dd Compare June 12, 2020 05:27
@smitpatel smitpatel force-pushed the smit/splitincludenotracking branch from fa7f3dd to 7bd6ff0 Compare June 12, 2020 05:29
@smitpatel smitpatel merged commit fc33923 into feature/splitInclude Jun 12, 2020
@smitpatel smitpatel deleted the smit/splitincludenotracking branch June 12, 2020 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

@maumar maumar Awaiting requested review from maumar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smitpatel @roji