Fix to issues around entity comparisons in query #11287
Closed
+766
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#11022 - GroupJoin with an entity object as a key fails #10974 - Query: Include Collection group by reference throws exception #11245 - Query: compilation error for queries with join where the inner key is navigation - Added step to the QueryOptimizer that converts entity qsre comparison to key comparisons instead for order by join and group join, - Improved logic of join/groupjoin inner key navigation rewrite to correctly handle case when navigation is the final operator (i.e. no scalar is projected at the end), - Improved "requires materialization" logic to correctly mark qsre projected out of subquery that is a result of nav rewrite of join/groupjoin inner key.
smitpatel
reviewed
Mar 15, 2018
| foreach (var ordering in orderByClause.Orderings) | ||
| { | ||
| if (ordering.Expression is QuerySourceReferenceExpression qsre | ||
| && TryGetEntityPrimaryKeys(qsre.ReferencedQuerySource, out var keys)) |
There was a problem hiding this comment.
keys name it keyProperties
|
closing in favor of #11289 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11022 - GroupJoin with an entity object as a key fails
#10974 - Query: Include Collection group by reference throws exception
#11245 - Query: compilation error for queries with join where the inner key is navigation