Improve exception messages #10894
Merged
Improve exception messages #10894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
approved these changes
Feb 6, 2018
| /// <summary> | ||
| /// This API supports the Entity Framework Core infrastructure and is not intended to be used | ||
| /// directly from your code. This API may change or be removed in future releases. | ||
| /// </summary> |
| <value>The foreign key {foreignKey} set on '{dependentEntityType}' matches an entity of type '{foundPrincipalEntityType}', however the principal entity type should be assignable to '{principalEntityType}'. Consider using 'DbContextOptionsBuilder.EnableSensitiveDataLogging' to see the key values.</value> | ||
| </data> | ||
| <data name="IncompatiblePrincipalEntrySensitive" xml:space="preserve"> | ||
| <value>The foreign key '{foreignKeyValues}' set on '{dependentEntityType}' with the key value '{keyValue}' matches an entity of type '{foundPrincipalEntityType}', however the principal entity type should be assignable to '{principalEntityType}'.</value> |
There was a problem hiding this comment.
I did not realize it was already sensitive. Ignore.
AndriySvyryd
force-pushed
the
Issue10856
branch
from
a3cfd3a to
5d0dc23
Compare
ajcvickers
approved these changes
Feb 6, 2018
Update transient error message Add sensitive data to the conceptual null exception Don't validate mapping for shadow properties created by convention Improve incompatible principal entity during fixup exception Correct property is already a navigation exception Fixes #8363 Fixes #8365 Fixes #9696 Fixes #9817 Fixes #10135 Fixes #10856
AndriySvyryd
force-pushed
the
Issue10856
branch
from
5d0dc23 to
779d0ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add key values to SaveChanges circular dependency message
Update transient error message to not reference SqlAzureExecutionStrategy
Add key values to the conceptual null exception
Don't validate mapping for shadow properties created by convention
Add incompatible principal entity during fixup exception
Don't reference 'Property' in property is already a navigation exception
Fixes #8363
Fixes #8365
Fixes #9696
Fixes #9817
Fixes #10135
Fixes #10856