Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure properties added via EntityBuilder that match CLR properties are marked as non-shadow #4714

Closed
AndriySvyryd opened this issue Mar 7, 2016 · 0 comments
Closed

Ensure properties added via EntityBuilder that match CLR properties are marked as non-shadow #4714

AndriySvyryd opened this issue Mar 7, 2016 · 0 comments
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
1.0.0

Comments

@AndriySvyryd
Copy link
Member

Currently it is possible to add a property using the string-based API with the same name as a property on the CLR type that hasn't been discovered by a convention, resulting in a shadow property by default.
@AndriySvyryd AndriySvyryd self-assigned this Mar 7, 2016
@rowanmiller rowanmiller added this to the 1.0.0 milestone Mar 8, 2016
AndriySvyryd added a commit that referenced this issue Apr 12, 2016
@AndriySvyryd
Ensure properties matching CLR properties are always marked as non-sh…
928a30a 
…adow

Fixes #4714
@AndriySvyryd AndriySvyryd mentioned this issue Apr 12, 2016
Closed
AndriySvyryd added a commit that referenced this issue Apr 14, 2016
@AndriySvyryd
Make IMutableEntityType.ClrType, IMutableProperty.ClrType and IMutabl…
03db99c 
…eProperty.IsShadowProperty readonly

Properties added using EntityTypeBuilder will always be non-shadow if the name matches a CLR property.
Properties added using EntityType can be shadow even if the name matches a CLR property.

Fixes #4934
Fixes #4714
@AndriySvyryd AndriySvyryd mentioned this issue Apr 14, 2016
Merged
AndriySvyryd added a commit that referenced this issue Apr 15, 2016
@AndriySvyryd
Make IMutableEntityType.ClrType, IMutableProperty.ClrType and IMutabl…
948abd5 
…eProperty.IsShadowProperty readonly

Properties added using EntityTypeBuilder will always be non-shadow if the name matches a CLR property.
Properties added using EntityType can be shadow even if the name matches a CLR property.

Fixes #4934
Fixes #4714
AndriySvyryd added a commit that referenced this issue Apr 15, 2016
@AndriySvyryd
Make IMutableEntityType.ClrType, IMutableProperty.ClrType and IMutabl…
5fce4e2 
…eProperty.IsShadowProperty readonly

Properties added using EntityTypeBuilder will always be non-shadow if the name matches a CLR property.
Properties added using EntityType can be shadow even if the name matches a CLR property.

Fixes #4934
Fixes #4714
@AndriySvyryd AndriySvyryd removed their assignment Apr 15, 2016
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@ajcvickers @rowanmiller @AndriySvyryd