Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the ordering as the identifier when translating VALUES #33436

Closed
roji opened this issue Mar 30, 2024 · 3 comments · Fixed by #33439
Closed

Set the ordering as the identifier when translating VALUES #33436

roji opened this issue Mar 30, 2024 · 3 comments · Fixed by #33439
Assignees
@roji
Labels
area-primitive-collections area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
9.0.0

Comments

@roji
Copy link
Member

roji commented Mar 30, 2024

Our translation of inline collections to SQL ValuesExpression does not specify an identifier, making it impossible to use project in certain query contexts.

Flagged by @maumar in #33410 (comment)
@roji roji self-assigned this Mar 30, 2024
@roji roji mentioned this issue Mar 30, 2024
Closed
roji added a commit to roji/efcore that referenced this issue Mar 30, 2024
@roji
Fixes around identifier and type mappings for ValuesExpression
824e6ef 
Closes dotnet#33436
Closes dotnet#33438
@roji roji mentioned this issue Mar 30, 2024
Merged
roji added a commit to roji/efcore that referenced this issue Mar 30, 2024
@roji
Fixes around identifier and type mappings for ValuesExpression
892fe6a 
Closes dotnet#33436
Closes dotnet#33438
roji added a commit to roji/efcore that referenced this issue Mar 30, 2024
@roji
Fixes around identifier and type mappings for ValuesExpression
2b507ab 
Closes dotnet#33436
Closes dotnet#33438
roji added a commit that referenced this issue Mar 31, 2024
@roji
Fixes around identifier and type mappings for ValuesExpression (#33439)
c89731a 
Closes #33436
Closes #33438
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Mar 31, 2024
@roji roji added this to the 9.0.0 milestone Mar 31, 2024
@ajcvickers ajcvickers modified the milestones: 9.0.0, 9.0.0-preview4 Apr 2, 2024
@maumar
Copy link
Contributor

maumar commented Apr 6, 2024

@roji, should we patch this, given that #33410 is a regression and the fix is not too complicated?

@maumar maumar reopened this Apr 6, 2024
@roji
Copy link
Member Author

roji commented Apr 6, 2024

See #33438 (comment)

@roji
Copy link
Member Author

roji commented Apr 15, 2024

Decision: we won't backport this since the workaround is trivial (add AsEnumerable()), and this doesn't actually address the customer-reported issue (which is about Concat, whereas this fixed Union). If additional user reports come in, we can reconsider.

@roji roji closed this as completed Apr 15, 2024
@roji roji modified the milestones: 9.0.0-preview4, 9.0.0 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-primitive-collections area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Fixes around identifier and type mappings for ValuesExpression roji/efcore
3 participants
@ajcvickers @maumar @roji