Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change IStateManager.StartTrackingFromQuery to use ISnapshot instead of ValueBuffer #31117

Closed
Tracked by #26544
AndriySvyryd opened this issue Jun 21, 2023 · 0 comments · Fixed by #32099
Closed
Tracked by #26544

Change IStateManager.StartTrackingFromQuery to use ISnapshot instead of ValueBuffer #31117

AndriySvyryd opened this issue Jun 21, 2023 · 0 comments · Fixed by #32099
Labels
area-change-tracking area-perf area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
9.0.0

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Jun 21, 2023 •
edited
Loading

A new implementation of SnapshotFactoryFactory could return the expression that creates a snapshot instance based on the variable expressions corresponding to the shadow properties. This will allow it to be inlined into the shaper.
@AndriySvyryd AndriySvyryd mentioned this issue Jun 21, 2023
Open
8 tasks
@ajcvickers ajcvickers self-assigned this Jul 7, 2023
@ajcvickers ajcvickers added this to the Backlog milestone Jul 7, 2023
AndriySvyryd added a commit that referenced this issue Oct 19, 2023
@AndriySvyryd
Change IStateManager.StartTrackingFromQuery to use ISnapshot instead …
62d37d0 
…of ValueBuffer

Fixes #31117
AndriySvyryd added a commit that referenced this issue Oct 19, 2023
@AndriySvyryd
Change IStateManager.StartTrackingFromQuery to use ISnapshot instead …
82edf40 
…of ValueBuffer

Fixes #31117
@AndriySvyryd AndriySvyryd mentioned this issue Oct 19, 2023
Merged
AndriySvyryd added a commit that referenced this issue Oct 19, 2023
@AndriySvyryd
Change IStateManager.StartTrackingFromQuery to use ISnapshot instead …
dca6da6 
…of ValueBuffer

Fixes #31117
AndriySvyryd added a commit that referenced this issue Oct 19, 2023
@AndriySvyryd
Change IStateManager.StartTrackingFromQuery to use ISnapshot instead …
05ee52e 
…of ValueBuffer

Fixes #31117
AndriySvyryd added a commit that referenced this issue Oct 19, 2023
@AndriySvyryd
Change IStateManager.StartTrackingFromQuery to use ISnapshot instead …
56df35f 
…of ValueBuffer

Fixes #31117
Part of #26544
AndriySvyryd added a commit that referenced this issue Oct 19, 2023
@AndriySvyryd
Change IStateManager.StartTrackingFromQuery to use ISnapshot instead …
3419fbc 
…of ValueBuffer

Fixes #31117
Part of #26544
AndriySvyryd added a commit that referenced this issue Oct 24, 2023
@AndriySvyryd
Change IStateManager.StartTrackingFromQuery to use ISnapshot instead …
00d51eb 
…of ValueBuffer (#32099)

Fixes #31117
Part of #26544
@ajcvickers ajcvickers modified the milestones: Backlog, 9.0.0 Nov 14, 2023
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Nov 14, 2023
@ajcvickers ajcvickers removed their assignment Nov 14, 2023
@ajcvickers ajcvickers modified the milestones: 9.0.0, 9.0.0-preview1 Jan 31, 2024
@roji roji modified the milestones: 9.0.0-preview1, 9.0.0 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-change-tracking area-perf area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Change IStateManager.StartTrackingFromQuery to use ISnapshot instead of ValueBuffer dotnet/efcore
3 participants
@ajcvickers @roji @AndriySvyryd