TryRewriteEntityEquality and NotEqual comparison of CompositePrimaryKey

[dmitry-lipetsk]

I not sure, but seems this code has mistake:

efcore/src/EFCore.Relational/Query/RelationalSqlTranslatingExpressionVisitor.cs

Lines 1397 to 1409 in 03c1ba5

	result = Visit(
	primaryKeyProperties.Select(
	p =>
	{
	var comparison = Expression.Call(
	_objectEqualsMethodInfo,
	Expression.Convert(CreatePropertyAccessExpression(left, p), typeof(object)),
	Expression.Convert(CreatePropertyAccessExpression(right, p), typeof(object)));
	return nodeType == ExpressionType.Equal
	? (Expression)comparison
	: Expression.Not(comparison);
	}).Aggregate((l, r) => Expression.AndAlso(l, r)));

In case of obj1.CompositePK != obj2.CompositePK need generate SQL with OR:

NOT(obj1.CompositePK.part1==obj2.CompositePK.part1) OR NOT(obj1.CompositePK.part2==obj2.CompositePK.part2)

Your code generates SQL with AND:

NOT(obj1.CompositePK.part1==obj2.CompositePK.part1) AND NOT(obj1.CompositePK.part2==obj2.CompositePK.part2)

?

[maumar]

it indeed is a bug which results in data corruption - possible candidate for patch? @ajcvickers