Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IntegerGeneratorEndToEndInMemoryTest is flaky #17672

Closed
AndriySvyryd opened this issue Sep 7, 2019 · 7 comments · Fixed by #22420
Closed

IntegerGeneratorEndToEndInMemoryTest is flaky #17672

AndriySvyryd opened this issue Sep 7, 2019 · 7 comments · Fixed by #22420
Labels
closed-could-not-reproduce

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Sep 7, 2019 •
edited
Loading

Can_use_sequence_end_to_end_from_multiple_contexts_concurrently_async()

Assert.Equal() Failure\nExpected: 50\nActual: 41
@AndriySvyryd AndriySvyryd added this to the 3.1.0 milestone Sep 7, 2019
@AndriySvyryd AndriySvyryd self-assigned this Sep 7, 2019
@AndriySvyryd AndriySvyryd mentioned this issue Oct 4, 2019
Closed
@ajcvickers ajcvickers removed this from the 3.1.0 milestone Oct 9, 2019
@ajcvickers
Copy link
Contributor

Marking for re-triage, since comment on #6872 implies that this is a product issue.

@ajcvickers
Copy link
Contributor

@AndriySvyryd We've been waiting for you to triage this. Is there good evidence that this is a product issue? If so, should it be in the 3.1 milestone?

@AndriySvyryd
Copy link
Member Author

@ajcvickers Yes and yes

@ajcvickers ajcvickers added this to the 3.1.0 milestone Oct 15, 2019
@ajcvickers ajcvickers self-assigned this Oct 15, 2019
@AndriySvyryd AndriySvyryd removed their assignment Oct 18, 2019
@ajcvickers
Copy link
Contributor

@AndriySvyryd Can't get this to fail; any tips? Any ideas where the product issue is?

@AndriySvyryd
Copy link
Member Author

I've seen it fail locally about 1 in 20 runs when running all tests.
Considering #18457, this is probably not high priority

@ajcvickers ajcvickers modified the milestones: 3.1.0, Backlog Oct 21, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, 5.0.0 Nov 13, 2019
@ajcvickers ajcvickers modified the milestones: 5.0.0, Backlog Mar 12, 2020
ajcvickers added a commit that referenced this issue Sep 5, 2020
@ajcvickers
Re-enable Can_use_sequence_end_to_end_from_multiple_contexts_concurre…
bf1c082 
…ntly_async for in-memory

I ran the test repeatedly:

* In the IDE for ~30 mins using run-until-fails
* 30 times in a full test run on the command line

and saw no failures.

Fixes #17672
@ajcvickers ajcvickers mentioned this issue Sep 5, 2020
Merged
@ajcvickers ajcvickers modified the milestones: Backlog, 5.0.0-rc2 Sep 5, 2020
ajcvickers added a commit that referenced this issue Sep 5, 2020
@ajcvickers
Re-enable Can_use_sequence_end_to_end_from_multiple_contexts_concurre…
fe29e9b 
…ntly_async for in-memory (#22420)

I ran the test repeatedly:

* In the IDE for ~30 mins using run-until-fails
* 30 times in a full test run on the command line

and saw no failures.

Fixes #17672
@ericstj
Copy link
Member

ericstj commented May 12, 2021

This was hit here: https://dev.azure.com/dnceng/public/_build/results?buildId=1135554&view=ms.vss-test-web.build-test-results-tab&runId=34454890&resultId=122792&paneView=debug

Assert.Equal() Failure
Expected: 50
Actual:   0


Stack trace
   at Microsoft.EntityFrameworkCore.IntegerGeneratorEndToEndInMemoryTest.Can_use_sequence_end_to_end_from_multiple_contexts_concurrently_async() in D:\workspace\_work\1\s\test\EFCore.InMemory.FunctionalTests\IntegerGeneratorEndToEndInMemoryTest.cs:line 113
--- End of stack trace from previous location ---

@AndriySvyryd AndriySvyryd reopened this May 12, 2021
@ericstj ericstj mentioned this issue May 12, 2021
Merged
@ericstj
Copy link
Member

ericstj commented May 13, 2021

False alarm, turns out it was a DI problem. dotnet/runtime#52691

@ericstj ericstj closed this as completed May 13, 2021
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-could-not-reproduce
Projects
None yet
Milestone
No milestone
3 participants
@ajcvickers @AndriySvyryd @ericstj