Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmos: Diagnostic events including statistics (query cost, activity id) #17298

Closed
AndriySvyryd opened this issue Aug 20, 2019 · 8 comments · Fixed by #25431
Closed

Cosmos: Diagnostic events including statistics (query cost, activity id) #17298

AndriySvyryd opened this issue Aug 20, 2019 · 8 comments · Fixed by #25431
Labels
area-cosmos area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
6.0.0

Comments

@AndriySvyryd
Copy link
Member

No description provided.

@smitpatel smitpatel mentioned this issue Aug 20, 2019
Closed
82 tasks
@ajcvickers ajcvickers added this to the Backlog milestone Aug 26, 2019
@AndriySvyryd AndriySvyryd mentioned this issue Nov 27, 2019
Closed
@ajcvickers ajcvickers mentioned this issue Apr 3, 2020
Closed
@ajcvickers
Copy link
Member

See the scenario in #20514

@ajcvickers ajcvickers mentioned this issue Apr 13, 2020
Closed
@smitpatel smitpatel mentioned this issue May 8, 2020
Closed
@AndriySvyryd AndriySvyryd mentioned this issue Dec 15, 2020
Closed
@ajcvickers ajcvickers modified the milestones: Backlog, 6.0.0 May 6, 2021
@ajcvickers ajcvickers mentioned this issue May 12, 2021
Closed
@ajcvickers ajcvickers mentioned this issue May 27, 2021
Closed
AndriySvyryd added a commit that referenced this issue Aug 5, 2021
@AndriySvyryd
Cosmos: Add diagnostic events with statistics
c74f3c1 
Fixes #17298
@AndriySvyryd AndriySvyryd removed their assignment Aug 5, 2021
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 5, 2021
@AndriySvyryd AndriySvyryd mentioned this issue Aug 5, 2021
Merged
AndriySvyryd added a commit that referenced this issue Aug 5, 2021
@AndriySvyryd
Cosmos: Add diagnostic events with statistics
524dcf1 
Fixes #17298
AndriySvyryd added a commit that referenced this issue Aug 5, 2021
@AndriySvyryd
Cosmos: Add diagnostic events with statistics
5237c80 
Fixes #17298
@roji
Copy link
Member

roji commented Aug 5, 2021

@AndriySvyryd assignment?

@AndriySvyryd
Copy link
Member Author

@roji It's fixed, why would it need assignment?

@roji
Copy link
Member

roji commented Aug 5, 2021

I thought we do assignments for fixed issues - this can be useful e.g. when people comment on the issue later, we know immediately who dealt with it. Looking at our closed issue list, it seems like sometimes we do it, sometimes not...

@AndriySvyryd
Copy link
Member Author

I always unassign myself, but remain subscribed

@roji
Copy link
Member

roji commented Aug 5, 2021

Will bring up in some upcoming meeting to see what people think...

@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-rc1 Aug 12, 2021
@ajcvickers ajcvickers mentioned this issue Sep 23, 2021
Closed
@ajcvickers ajcvickers modified the milestones: 6.0.0-rc1, 6.0.0 Nov 8, 2021
@chuckgiddens
Copy link

How do I enable this? Not mentioned anywhere but here!

@AndriySvyryd
Copy link
Member Author

AndriySvyryd commented Dec 29, 2023 •
edited
Loading

@chuckgiddens Same as with all events in EF Core you can use Logging or Diagnostic Listeners with events found in CosmosEventId

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-cosmos area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Cosmos: Add diagnostic events with statistics dotnet/efcore
5 participants
@ajcvickers @smitpatel @roji @chuckgiddens @AndriySvyryd