Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid creating new query roots in navigation rewrite for owned types #13000

Closed
AndriySvyryd opened this issue Aug 14, 2018 · 1 comment
Closed

Avoid creating new query roots in navigation rewrite for owned types #13000

AndriySvyryd opened this issue Aug 14, 2018 · 1 comment
Assignees
@maumar
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
2.2.0

Comments

@AndriySvyryd
Copy link
Member

The new behavior would be enabled through a switch to avoid changes to relational code
@AndriySvyryd AndriySvyryd added this to the 2.2.0 milestone Aug 14, 2018
@smitpatel smitpatel mentioned this issue Aug 14, 2018
Closed
82 tasks
maumar added a commit that referenced this issue Aug 16, 2018
@maumar
Fix to #13000 - Avoid creating new query roots in navigation rewrite …
7b33b65 
…for owned types

Fix is to add a property to NavigationRewritingExpressionVisitor. When the property is set to true owned navigations will not get converted into joins/groupjoins but rather left as they are. Because of this, we can no longer expect source of the navigation rewrite to be QSRE, but rather an arbitrary expression.
maumar added a commit that referenced this issue Aug 16, 2018
@maumar
Fix to #13000 - Avoid creating new query roots in navigation rewrite …
591baf1 
…for owned types

Fix is to add a property to NavigationRewritingExpressionVisitor. When the property is set to true owned navigations will not get converted into joins/groupjoins but rather left as they are. Because of this, we can no longer expect source of the navigation rewrite to be QSRE, but rather an arbitrary expression.
maumar added a commit that referenced this issue Aug 17, 2018
@maumar
Fix to #13000 - Avoid creating new query roots in navigation rewrite …
a706541 
…for owned types

Fix is to add a property to NavigationRewritingExpressionVisitor. When the property is set to true owned navigations will not get converted into joins/groupjoins but rather left as they are. Because of this, we can no longer expect source of the navigation rewrite to be QSRE, but rather an arbitrary expression.
maumar added a commit that referenced this issue Aug 17, 2018
@maumar
Fix to #13000 - Avoid creating new query roots in navigation rewrite …
8206561 
…for owned types

Fix is to add a property to NavigationRewritingExpressionVisitor. When the property is set to true owned navigations will not get converted into joins/groupjoins but rather left as they are. Because of this, we can no longer expect source of the navigation rewrite to be QSRE, but rather an arbitrary expression.
maumar added a commit that referenced this issue Aug 17, 2018
@maumar
Fix to #13000 - Avoid creating new query roots in navigation rewrite …
be2cab5 
…for owned types

Fix is to add a property to NavigationRewritingExpressionVisitor. When the property is set to true owned navigations will not get converted into joins/groupjoins but rather left as they are. Because of this, we can no longer expect source of the navigation rewrite to be QSRE, but rather an arbitrary expression.
maumar added a commit that referenced this issue Aug 17, 2018
@maumar
Fix to #13000 - Avoid creating new query roots in navigation rewrite …
efa187a 
…for owned types

Fix is to add a property to NavigationRewritingExpressionVisitor. When the property is set to true owned navigations will not get converted into joins/groupjoins but rather left as they are. Because of this, we can no longer expect source of the navigation rewrite to be QSRE, but rather an arbitrary expression.
@maumar
Copy link
Contributor

maumar commented Aug 17, 2018

fixed in efa187a

@maumar maumar closed this as completed Aug 17, 2018
@maumar maumar added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 17, 2018
@ajcvickers ajcvickers modified the milestones: 2.2.0-preview2, 2.2.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
3 participants
@ajcvickers @maumar @AndriySvyryd