Document that HasMaxLength(-1) means no maximum length (#30137)

Continues #29627

src/EFCore/Metadata/Builders/IConventionPropertyBuilder.cs

@@ -142,7 +142,9 @@ public interface IConventionPropertyBuilder : IConventionPropertyBaseBuilder
     /// <summary>
     ///     Configures the maximum length of data that can be stored in this property.
     /// </summary>
-    /// <param name="maxLength">The maximum length of data allowed in the property.</param>
+    /// <param name="maxLength">
+    /// The maximum length of data allowed in the property. A value of <c>-1</c> indicates that the property has no maximum length.
+    /// </param>
     /// <param name="fromDataAnnotation">Indicates whether the configuration was specified using a data annotation.</param>
     /// <returns>
     ///     The same builder instance if the configuration was applied,

src/EFCore/Metadata/Builders/PropertyBuilder.cs

@@ -84,7 +84,9 @@ public virtual PropertyBuilder IsRequired(bool required = true)
     ///     Configures the maximum length of data that can be stored in this property.
     ///     Maximum length can only be set on array properties (including <see cref="string" /> properties).
     /// </summary>
-    /// <param name="maxLength">The maximum length of data allowed in the property.</param>
+    /// <param name="maxLength">
+    /// The maximum length of data allowed in the property. A value of <c>-1</c> indicates that the property has no maximum length.
+    /// </param>
     /// <returns>The same builder instance so that multiple configuration calls can be chained.</returns>
     public virtual PropertyBuilder HasMaxLength(int maxLength)
     {

src/EFCore/Metadata/Builders/PropertyBuilder`.cs

@@ -56,7 +56,9 @@ public PropertyBuilder(IMutableProperty property)
     ///     Configures the maximum length of data that can be stored in this property.
     ///     Maximum length can only be set on array properties (including <see cref="string" /> properties).
     /// </summary>
-    /// <param name="maxLength">The maximum length of data allowed in the property.</param>
+    /// <param name="maxLength">
+    /// The maximum length of data allowed in the property. A value of <c>-1</c> indicates that the property has no maximum length.
+    /// </param>
     /// <returns>The same builder instance so that multiple configuration calls can be chained.</returns>
     public new virtual PropertyBuilder<TProperty> HasMaxLength(int maxLength)
         => (PropertyBuilder<TProperty>)base.HasMaxLength(maxLength);

src/EFCore/Metadata/Builders/TypeMappingConfigurationBuilder.cs

@@ -63,7 +63,9 @@ public virtual TypeMappingConfigurationBuilder HasAnnotation(string annotation,
     ///     Configures the maximum length of data that can be stored in this property.
     ///     Maximum length can only be set on array properties (including <see cref="string" /> properties).
     /// </summary>
-    /// <param name="maxLength">The maximum length of data allowed in the property.</param>
+    /// <param name="maxLength">
+    /// The maximum length of data allowed in the property. A value of <c>-1</c> indicates that the property has no maximum length.
+    /// </param>
     /// <returns>The same builder instance so that multiple configuration calls can be chained.</returns>
     public virtual TypeMappingConfigurationBuilder HasMaxLength(int maxLength)
     {

src/EFCore/Metadata/Builders/TypeMappingConfigurationBuilder`.cs

@@ -46,7 +46,9 @@ public TypeMappingConfigurationBuilder(PropertyConfiguration scalar)
     ///     Configures the maximum length of data that can be stored in this property.
     ///     Maximum length can only be set on array properties (including <see cref="string" /> properties).
     /// </summary>
-    /// <param name="maxLength">The maximum length of data allowed in the property.</param>
+    /// <param name="maxLength">
+    /// The maximum length of data allowed in the property. A value of <c>-1</c> indicates that the property has no maximum length.
+    /// </param>
     /// <returns>The same builder instance so that multiple configuration calls can be chained.</returns>
     public new virtual TypeMappingConfigurationBuilder<TProperty> HasMaxLength(int maxLength)
         => (TypeMappingConfigurationBuilder<TProperty>)base.HasMaxLength(maxLength);

src/EFCore/Metadata/IReadOnlyProperty.cs

@@ -67,7 +67,10 @@ CoreTypeMapping GetTypeMapping()
     ///     Gets the maximum length of data that is allowed in this property. For example, if the property is a <see cref="string" />
     ///     then this is the maximum number of characters.
     /// </summary>
-    /// <returns>The maximum length, or <see langword="null" /> if none is defined.</returns>
+    /// <returns>
+    /// The maximum length, <c>-1</c> if the property has no maximum length, or <see langword="null" /> if the maximum length hasn't been
+    /// set.
+    /// </returns>
     int? GetMaxLength();
 
     /// <summary>

src/EFCore/Metadata/Internal/Property.cs

@@ -304,8 +304,7 @@ private static bool DefaultIsConcurrencyToken
     /// </summary>
     public virtual int? SetMaxLength(int? maxLength, ConfigurationSource configurationSource)
     {
-        if (maxLength != null
-            && maxLength < -1)
+        if (maxLength is < -1)
         {
             throw new ArgumentOutOfRangeException(nameof(maxLength));
         }

src/EFCore/Metadata/Internal/PropertyConfiguration.cs

@@ -113,8 +113,7 @@ public virtual void Apply(IMutableProperty property)
     /// </summary>
     public virtual void SetMaxLength(int? maxLength)
     {
-        if (maxLength != null
-            && maxLength < -1)
+        if (maxLength is < -1)
         {
             throw new ArgumentOutOfRangeException(nameof(maxLength));
         }