Verify failures ProxyGraphUpdatesInMemoryTest

Fixes #11552 Failures were due to: * Lack of cascade update/delete support--tracked by #3924. * Lack of uniqueness constraint checking--tracked by #2166.
dotnet · Nov 26, 2020 · 9ead527 · 9ead527
1 parent 2433579
commit 9ead527
Show file tree

Hide file tree

Showing 2 changed files with 53 additions and 45 deletions.
diff --git a/test/EFCore.InMemory.FunctionalTests/GraphUpdates/GraphUpdatesInMemoryTest.cs b/test/EFCore.InMemory.FunctionalTests/GraphUpdates/GraphUpdatesInMemoryTest.cs
@@ -19,136 +19,136 @@ public override void Required_many_to_one_dependents_are_cascade_deleted_in_stor
             CascadeTiming? cascadeDeleteTiming,
             CascadeTiming? deleteOrphansTiming)
         {
-            // FK uniqueness not enforced in in-memory database
+            // In-memory database does not support cascade update/delete. Issue #3924.
         }
 
         public override void Optional_many_to_one_dependents_are_orphaned_in_store(
             CascadeTiming? cascadeDeleteTiming,
             CascadeTiming? deleteOrphansTiming)
         {
-            // FK uniqueness not enforced in in-memory database
+            // In-memory database does not support cascade update/delete. Issue #3924.
         }
 
         public override void Required_many_to_one_dependents_with_alternate_key_are_cascade_deleted_in_store(
             CascadeTiming? cascadeDeleteTiming,
             CascadeTiming? deleteOrphansTiming)
         {
-            // FK uniqueness not enforced in in-memory database
+            // In-memory database does not support cascade update/delete. Issue #3924.
         }
 
         public override void Optional_many_to_one_dependents_with_alternate_key_are_orphaned_in_store(
             CascadeTiming? cascadeDeleteTiming,
             CascadeTiming? deleteOrphansTiming)
         {
-            // FK uniqueness not enforced in in-memory database
+            // In-memory database does not support cascade update/delete. Issue #3924.
         }
 
         public override void Optional_one_to_one_relationships_are_one_to_one(
             CascadeTiming? deleteOrphansTiming)
         {
-            // FK uniqueness not enforced in in-memory database
+            // FK uniqueness not enforced in in-memory database. Issue #2166.
         }
 
         public override void Required_one_to_one_relationships_are_one_to_one(
             CascadeTiming? deleteOrphansTiming)
         {
-            // FK uniqueness not enforced in in-memory database
+            // FK uniqueness not enforced in in-memory database. Issue #2166.
         }
 
         public override void Save_required_one_to_one_changed_by_reference(
             ChangeMechanism changeMechanism,
             CascadeTiming? deleteOrphansTiming)
         {
-            // FK uniqueness not enforced in in-memory database
+            // FK uniqueness not enforced in in-memory database. Issue #2166.
         }
 
         public override void Sever_required_one_to_one(
             ChangeMechanism changeMechanism,
             CascadeTiming? deleteOrphansTiming)
         {
-            // FK uniqueness not enforced in in-memory database
+            // FK uniqueness not enforced in in-memory database. Issue #2166.
         }
 
         public override void Required_one_to_one_are_cascade_deleted_in_store(
             CascadeTiming? cascadeDeleteTiming,
             CascadeTiming? deleteOrphansTiming)
         {
-            // FK uniqueness not enforced in in-memory database
+            // In-memory database does not support cascade update/delete. Issue #3924.
         }
 
         public override void Required_non_PK_one_to_one_are_cascade_deleted_in_store(
             CascadeTiming? cascadeDeleteTiming,
             CascadeTiming? deleteOrphansTiming)
         {
-            // FK uniqueness not enforced in in-memory database
+            // In-memory database does not support cascade update/delete. Issue #3924.
         }
 
         public override void Optional_one_to_one_are_orphaned_in_store(
             CascadeTiming? cascadeDeleteTiming,
             CascadeTiming? deleteOrphansTiming)
         {
-            // FK uniqueness not enforced in in-memory database
+            // In-memory database does not support cascade update/delete. Issue #3924.
         }
 
         public override void Required_one_to_one_are_cascade_detached_when_Added(
             CascadeTiming? cascadeDeleteTiming,
             CascadeTiming? deleteOrphansTiming)
         {
-            // FK uniqueness not enforced in in-memory database
+            // FK uniqueness not enforced in in-memory database. Issue #2166.
         }
 
         public override void Required_non_PK_one_to_one_are_cascade_detached_when_Added(
             CascadeTiming? cascadeDeleteTiming,
             CascadeTiming? deleteOrphansTiming)
         {
-            // FK uniqueness not enforced in in-memory database
+            // FK uniqueness not enforced in in-memory database. Issue #2166.
         }
 
         public override void Optional_one_to_one_with_AK_relationships_are_one_to_one(
             CascadeTiming? deleteOrphansTiming)
         {
-            // FK uniqueness not enforced in in-memory database
+            // FK uniqueness not enforced in in-memory database. Issue #2166.
         }
 
         public override void Required_one_to_one_with_AK_relationships_are_one_to_one(
             CascadeTiming? deleteOrphansTiming)
         {
-            // FK uniqueness not enforced in in-memory database
+            // FK uniqueness not enforced in in-memory database. Issue #2166.
         }
 
         public override void Required_one_to_one_with_alternate_key_are_cascade_deleted_in_store(
             CascadeTiming? cascadeDeleteTiming,
             CascadeTiming? deleteOrphansTiming)
         {
-            // FK uniqueness not enforced in in-memory database
+            // In-memory database does not support cascade update/delete. Issue #3924.
         }
 
         public override void Required_non_PK_one_to_one_with_alternate_key_are_cascade_deleted_in_store(
             CascadeTiming? cascadeDeleteTiming,
             CascadeTiming? deleteOrphansTiming)
         {
-            // FK uniqueness not enforced in in-memory database
+            // In-memory database does not support cascade update/delete. Issue #3924.
         }
 
         public override void Optional_one_to_one_with_alternate_key_are_orphaned_in_store(
             CascadeTiming? cascadeDeleteTiming,
             CascadeTiming? deleteOrphansTiming)
         {
-            // FK uniqueness not enforced in in-memory database
+            // In-memory database does not support cascade update/delete. Issue #3924.
         }
 
         public override void Required_non_PK_one_to_one_with_alternate_key_are_cascade_detached_when_Added(
             CascadeTiming? cascadeDeleteTiming,
             CascadeTiming? deleteOrphansTiming)
         {
-            // FK uniqueness not enforced in in-memory database
+            // FK uniqueness not enforced in in-memory database. Issue #2166.
         }
 
         public override void Required_one_to_one_with_alternate_key_are_cascade_detached_when_Added(
             CascadeTiming? cascadeDeleteTiming,
             CascadeTiming? deleteOrphansTiming)
         {
-            // FK uniqueness not enforced in in-memory database
+            // FK uniqueness not enforced in in-memory database. Issue #2166.
         }
 
         protected override void ExecuteWithStrategyInTransaction(

diff --git a/test/EFCore.InMemory.FunctionalTests/GraphUpdates/ProxyGraphUpdatesInMemoryTest.cs b/test/EFCore.InMemory.FunctionalTests/GraphUpdates/ProxyGraphUpdatesInMemoryTest.cs
@@ -20,79 +20,87 @@ protected ProxyGraphUpdatesInMemoryTestBase(TFixture fixture)
             {
             }
 
-            // #11552
-            public override void Save_required_one_to_one_changed_by_reference(ChangeMechanism changeMechanism)
-            {
-            }
-
-            public override void Optional_one_to_one_relationships_are_one_to_one()
-            {
-            }
-
-            public override void Optional_one_to_one_with_AK_relationships_are_one_to_one()
+            public override void Optional_many_to_one_dependents_are_orphaned_in_store(
+                CascadeTiming cascadeDeleteTiming,
+                CascadeTiming deleteOrphansTiming)
             {
+                // In-memory database does not support cascade update/delete. Issue #3924.
             }
 
             public override void Optional_many_to_one_dependents_with_alternate_key_are_orphaned_in_store(
                 CascadeTiming cascadeDeleteTiming,
                 CascadeTiming deleteOrphansTiming)
             {
+                // In-memory database does not support cascade update/delete. Issue #3924.
             }
 
-            public override void Optional_many_to_one_dependents_are_orphaned_in_store(
+            public override void Required_many_to_one_dependents_are_cascade_deleted_in_store(
                 CascadeTiming cascadeDeleteTiming,
                 CascadeTiming deleteOrphansTiming)
             {
+                // In-memory database does not support cascade update/delete. Issue #3924.
             }
 
-            public override void Required_one_to_one_are_cascade_detached_when_Added(
+            public override void Required_many_to_one_dependents_with_alternate_key_are_cascade_deleted_in_store(
                 CascadeTiming cascadeDeleteTiming,
                 CascadeTiming deleteOrphansTiming)
             {
+                // In-memory database does not support cascade update/delete. Issue #3924.
             }
 
-            public override void Required_one_to_one_relationships_are_one_to_one()
+            public override void Required_non_PK_one_to_one_are_cascade_detached_when_Added(
+                CascadeTiming cascadeDeleteTiming,
+                CascadeTiming deleteOrphansTiming)
             {
+                // FK uniqueness not enforced in in-memory database. Issue #2166.
             }
 
-            public override void Required_one_to_one_with_AK_relationships_are_one_to_one()
+            public override void Required_non_PK_one_to_one_with_alternate_key_are_cascade_detached_when_Added(
+                CascadeTiming cascadeDeleteTiming,
+                CascadeTiming deleteOrphansTiming)
             {
+                // FK uniqueness not enforced in in-memory database. Issue #2166.
             }
 
-            public override void Required_one_to_one_with_alternate_key_are_cascade_detached_when_Added(
+            public override void Required_one_to_one_are_cascade_detached_when_Added(
                 CascadeTiming cascadeDeleteTiming,
                 CascadeTiming deleteOrphansTiming)
             {
+                // FK uniqueness not enforced in in-memory database. Issue #2166.
             }
 
             public override void Required_one_to_one_with_alternate_key_are_cascade_deleted_in_store(
                 CascadeTiming cascadeDeleteTiming,
                 CascadeTiming deleteOrphansTiming)
             {
+                // In-memory database does not support cascade update/delete. Issue #3924.
             }
 
-            public override void Required_many_to_one_dependents_are_cascade_deleted_in_store(
+            public override void Required_one_to_one_with_alternate_key_are_cascade_detached_when_Added(
                 CascadeTiming cascadeDeleteTiming,
                 CascadeTiming deleteOrphansTiming)
             {
+                // FK uniqueness not enforced in in-memory database. Issue #2166.
             }
 
-            public override void Required_many_to_one_dependents_with_alternate_key_are_cascade_deleted_in_store(
-                CascadeTiming cascadeDeleteTiming,
-                CascadeTiming deleteOrphansTiming)
+            public override void Optional_one_to_one_relationships_are_one_to_one()
             {
+                // FK uniqueness not enforced in in-memory database. Issue #2166.
             }
 
-            public override void Required_non_PK_one_to_one_are_cascade_detached_when_Added(
-                CascadeTiming cascadeDeleteTiming,
-                CascadeTiming deleteOrphansTiming)
+            public override void Optional_one_to_one_with_AK_relationships_are_one_to_one()
             {
+                // FK uniqueness not enforced in in-memory database. Issue #2166.
             }
 
-            public override void Required_non_PK_one_to_one_with_alternate_key_are_cascade_detached_when_Added(
-                CascadeTiming cascadeDeleteTiming,
-                CascadeTiming deleteOrphansTiming)
+            public override void Required_one_to_one_relationships_are_one_to_one()
+            {
+                // FK uniqueness not enforced in in-memory database. Issue #2166.
+            }
+
+            public override void Required_one_to_one_with_AK_relationships_are_one_to_one()
             {
+                // FK uniqueness not enforced in in-memory database. Issue #2166.
             }
 
             protected override void ExecuteWithStrategyInTransaction(