Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent managed messaging initialization if profiler is not loaded #5540

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

jander-msft
Copy link
Member

Summary

When parameter capturing is not enabled and no other feature is enabled that requires the profiler, the startup hook will throw a DllNotFoundException exception, which appears in the /exceptions history backlog. This happens because the startup hook is attempting to initialize the managed messaging dispatcher, which requires the profiler to have been loaded.

Overview of changes:

  • Add an additional check of whether the profiler is loaded before attempting to initialize the dispatcher.
  • Add tests to verify the availability of the dispatcher based on the existence of the profiler.
Release Notes Entry

@jander-msft jander-msft requested a review from a team as a code owner October 16, 2023 18:01
@ghost ghost added the needs-review label Oct 16, 2023
wiktork
wiktork previously approved these changes Oct 16, 2023
@ghost ghost removed the needs-review label Oct 16, 2023
@ghost ghost removed the needs-review label Oct 17, 2023
@jander-msft jander-msft merged commit 9d741dd into dotnet:main Oct 17, 2023
@jander-msft jander-msft deleted the managed-messaging-disable branch October 17, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants