-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ExceptionsStore to allow multiple callbacks #5213
Merged
jander-msft
merged 2 commits into
dotnet:main
from
jander-msft:exceptions-callback-refactor
Aug 29, 2023
Merged
Change ExceptionsStore to allow multiple callbacks #5213
jander-msft
merged 2 commits into
dotnet:main
from
jander-msft:exceptions-callback-refactor
Aug 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-review
label
Aug 28, 2023
kkeirstead
reviewed
Aug 28, 2023
src/Tests/Microsoft.Diagnostics.Monitoring.Tool.UnitTests/ExceptionsStoreTests.cs
Outdated
Show resolved
Hide resolved
ghost
removed
the
needs-review
label
Aug 28, 2023
kkeirstead
reviewed
Aug 28, 2023
src/Tests/Microsoft.Diagnostics.Monitoring.Tool.UnitTests/ExceptionsStoreTests.cs
Outdated
Show resolved
Hide resolved
kkeirstead
reviewed
Aug 28, 2023
src/Tests/Microsoft.Diagnostics.Monitoring.Tool.UnitTests/ExceptionsStoreTests.cs
Outdated
Show resolved
Hide resolved
kkeirstead
reviewed
Aug 28, 2023
src/Tests/Microsoft.Diagnostics.Monitoring.Tool.UnitTests/ExceptionsStoreTests.cs
Outdated
Show resolved
Hide resolved
kkeirstead
reviewed
Aug 28, 2023
src/Tests/Microsoft.Diagnostics.Monitoring.Tool.UnitTests/ExceptionsStoreTests.cs
Outdated
Show resolved
Hide resolved
kkeirstead
reviewed
Aug 28, 2023
ghost
added
the
needs-review
label
Aug 28, 2023
kkeirstead
reviewed
Aug 28, 2023
kkeirstead
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the
ExceptionsStore
callback notion in order to allow multiple callbacks and separate the callback behavior from the store implementation. These changes allow future callbacks to be added without having to chain exception store implementations together and to separate the callback concerns from the store concerns.Overview of Changes
IExceptionsStoreCallback
andIExceptionsStoreCallbackFactory
interfaces; the latter allows breaking circular dependencies between exception stores and callback implementations that would prevent DI composition.ConfiguredExceptionsStore
intoExceptionsStoreLimitsCallback
andExceptionsStoreLimitsCallbackFactory
.ConfiguredExceptionsStoreTests
intoExceptionsStoreTests
andExceptionsStoreLimitsCallbackTests
to separate testing concerns between testing the now-only exceptions store implementation and the callback implementation.Release Notes Entry