Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remarks of String.ReplaceLineEndings #7908

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Fix remarks of String.ReplaceLineEndings #7908

merged 1 commit into from
Apr 4, 2022

Conversation

xparadoxical
Copy link
Contributor

Summary

In remarks of both System.String.ReplaceLineEndings methods, every paragraph that isn't the first one is displayed in a code block because of 4 space indentation. This PR removes that identation and also line breaks in paragraphs to let the frontend handle line breaking.

@xparadoxical xparadoxical requested a review from a team as a code owner April 2, 2022 00:20
@dnfadmin
Copy link

dnfadmin commented Apr 2, 2022

CLA assistant check
All CLA requirements met.

@opbld31
Copy link

opbld31 commented Apr 2, 2022

Docs Build status updates of commit fa3633f:

✅ Validation status: passed

File Status Preview URL Details
xml/System/String.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making that fix @xparadoxical

I've reviewed the changes and I'll :shipit: now.

@BillWagner BillWagner merged commit d04ee76 into dotnet:main Apr 4, 2022
@xparadoxical xparadoxical deleted the string-replacelineendings branch April 4, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants