Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Environment.ProcessorCount for containers #6668

Merged
merged 9 commits into from
Apr 29, 2021
Merged

Conversation

richlander
Copy link
Member

@richlander richlander commented Apr 27, 2021

Summary

The current text for Environment.ProcessorCount does not account for containers.

@opbld34
Copy link

opbld34 commented Apr 27, 2021

Docs Build status updates of commit 104b668:

✅ Validation status: passed

File Status Preview URL Details
xml/System/Environment.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

xml/System/Environment.xml Outdated Show resolved Hide resolved
xml/System/Environment.xml Outdated Show resolved Hide resolved
@opbld30
Copy link

opbld30 commented Apr 28, 2021

Docs Build status updates of commit ff4d7b4:

✅ Validation status: passed

File Status Preview URL Details
xml/System/Environment.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld32
Copy link

opbld32 commented Apr 28, 2021

Docs Build status updates of commit 6694da2:

✅ Validation status: passed

File Status Preview URL Details
xml/System/Environment.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld30
Copy link

opbld30 commented Apr 28, 2021

Docs Build status updates of commit e02d2dd:

✅ Validation status: passed

File Status Preview URL Details
xml/System/Environment.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld30
Copy link

opbld30 commented Apr 28, 2021

Docs Build status updates of commit 4cfe0b8:

✅ Validation status: passed

File Status Preview URL Details
xml/System/Environment.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

xml/System/Environment.xml Outdated Show resolved Hide resolved
@richlander
Copy link
Member Author

Tell me if that's it and then we can merge.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@opbld34
Copy link

opbld34 commented Apr 29, 2021

Docs Build status updates of commit 56265b3:

✅ Validation status: passed

File Status Preview URL Details
xml/System/Environment.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Member

@AntonLapounov AntonLapounov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@richlander
Copy link
Member Author

This PR is ready to go, per runtime team.

@opbld34
Copy link

opbld34 commented Apr 29, 2021

Docs Build status updates of commit e6a9adf:

✅ Validation status: passed

File Status Preview URL Details
xml/System/Environment.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants