-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CBOR and platform check API updates #4992
Conversation
Docs Build status updates of commit af9c153: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OperatingSystem type-related changes looks good, thanks
@@ -20,7 +20,7 @@ | |||
</Attribute> | |||
</Attributes> | |||
<Docs> | |||
<summary>To be added.</summary> | |||
<summary>The exception that is thrown when Concise Binary Object Representation (CBOR) content is invalid.</summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to do this for every type? It feels redundant since the namespace also contains the acronym. I would suggest expanding it only for the CborWriter and CborReader classes, since they are the entrypoints to this particular API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than one comment, CBOR changes LGTM
@@ -1,6 +1,6 @@ | |||
<Namespace Name="System.Formats.Cbor"> | |||
<Docs> | |||
<summary>To be added.</summary> | |||
<summary>Contains types used in reading and writing data in the Concise Binary Object Representation (CBOR) format.</summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eiriktsarpalis Thanks for reviewing. I removed the spelled out acronym from all but reader and writer, but I also added a namespace summary here. Does this look okay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's perfect, thanks!
Docs Build status updates of commit 59584ba: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Spell out CBOR acronym on first use.
Update platform check method descriptions.
(Hide whitespace changes in diff.)