Update HandleProcessCorruptedStateExceptionsAttribute docs #3335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that the handling of process corruption exceptions are not supported by design, and this attribute has no effect (https://github.com/dotnet/coreclr/issues/9045#issuecomment-290159433). To avoid confusion the documentation should be updated to reflect this .NET Core specific behaviour. Related: #3051
|
Yes, this is by design. |
|
@mairaw Why is there no preview link in the build report? |
|
It would be good to request that indeed. It might hard to determine the exact URLs touched on a PR because a single file generates multiple pages. |
gewarren
approved these changes
Dec 12, 2019
xml/System.Runtime.ExceptionServices/HandleProcessCorruptedStateExceptionsAttribute.xml
Outdated
Show resolved
Hide resolved
…teExceptionsAttribute.xml Apply suggestions Co-Authored-By: Genevieve Warren <[email protected]>
|
I made some small updates to avoid issues for loc and avoid reintroducing the same acronym that was already defined. We can merge once build finishes. Thanks @Gnbrkm41! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It appears that the handling of process corruption exceptions are not supported by design, and this attribute has no effect (https://github.com/dotnet/coreclr/issues/9045#issuecomment-290159433). To avoid confusion the documentation should be updated to reflect this .NET Core specific behaviour.
Fixes #3051
cc @jkotas - Could you confirm that this is indeed by design?