Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify correct instance of ChatFinishReason to serialize #10825

Closed
jochenkirstaetter opened this issue Jan 9, 2025 · 2 comments · Fixed by dotnet/extensions#5790
Closed

Specify correct instance of ChatFinishReason to serialize #10825

jochenkirstaetter opened this issue Jan 9, 2025 · 2 comments · Fixed by dotnet/extensions#5790
Assignees
@gewarren
Labels
area-Extensions-AI

Comments

@jochenkirstaetter
Copy link

Type of issue

Typo

Description

The Definition paragraphs refers to serializing an instance of ChatRole instead of the correct ChatFinishReason instance.

Provides a JsonConverter for serializing ChatRole instances.

The correct link would be ChatFinishReason

Page URL

https://learn.microsoft.com/en-us/dotnet/api/microsoft.extensions.ai.chatfinishreason.converter?view=net-9.0-pp&viewFallbackFrom=net-8.0

Content source URL

https://github.com/dotnet/dotnet-api-docs/blob/main/xml/Microsoft.Extensions.AI/ChatFinishReason+Converter.xml

Document Version Independent Id

078479b9-7058-bea0-a686-53a9281774b5

Article author

@dotnet-bot
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jan 9, 2025
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 9, 2025
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

1 similar comment
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

gewarren added a commit to dotnet/extensions that referenced this issue Jan 11, 2025
@gewarren
Fix XML comment
779cd7c 
Fixes dotnet/dotnet-api-docs#10825
@gewarren gewarren mentioned this issue Jan 11, 2025
Merged
@gewarren gewarren self-assigned this Jan 11, 2025
@gewarren gewarren removed untriaged New issue has not been triaged by the area owner needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gewarren gewarren

Labels
area-Extensions-AI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix XML comment dotnet/extensions
2 participants
@jochenkirstaetter @gewarren