Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[diagnostics] Add InstrumentAdvice details to instrumentation doc #43640

Merged
merged 6 commits into from
Jan 14, 2025
Merged

[diagnostics] Add InstrumentAdvice details to instrumentation doc #43640

merged 6 commits into from
Jan 14, 2025

Conversation

CodeBlanch
Copy link
Contributor

@CodeBlanch CodeBlanch commented Nov 19, 2024 •
edited by github-actions bot
Loading

Summary

Add content + example showing the System.Diagnostics.DiagnosticSource v9.0.0 InstrumentAdvice API.

The goal is to link to this from the OTel .NET docs: https://github.com/open-telemetry/opentelemetry-dotnet/blob/e3665c95c21082f5675cb4d5863051201f640397/docs/metrics/customizing-the-sdk/README.md?plain=1#L244-L252

Internal previews

📄 File 🔗 Preview link
docs/core/diagnostics/metrics-instrumentation.md Creating metrics

@CodeBlanch CodeBlanch requested review from tommcdon and a team as code owners November 19, 2024 19:21
@dotnetrepoman dotnetrepoman bot added this to the November 2024 milestone Nov 19, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Nov 19, 2024
noahfalk
noahfalk approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looked good to me overall. A few suggestions inline.

@CodeBlanch CodeBlanch mentioned this pull request Dec 19, 2024
Merged
2 tasks
@BillWagner BillWagner closed this Jan 14, 2025
@BillWagner BillWagner reopened this Jan 14, 2025
@dotnetrepoman dotnetrepoman bot modified the milestones: November 2024, January 2025 Jan 14, 2025
@BillWagner BillWagner enabled auto-merge (squash) January 14, 2025 15:37
@BillWagner BillWagner merged commit d703cbd into dotnet:main Jan 14, 2025
10 checks passed
@CodeBlanch CodeBlanch deleted the diagnostics-instrumentadvice branch January 14, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas cijothomas left review comments

@tarekgh tarekgh tarekgh approved these changes

@noahfalk noahfalk noahfalk approved these changes

@tommcdon tommcdon Awaiting requested review from tommcdon tommcdon is a code owner

Assignees
No one assigned
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Milestone
January 2025
Development

Successfully merging this pull request may close these issues.
5 participants
@CodeBlanch @cijothomas @noahfalk @tarekgh @BillWagner