Add a reference for new .NET 8 metrics #37213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahfalk
force-pushed
the
metrics_reference
branch
from
1b2c439 to
57e96f7
Compare
Part of the work for dotnet#36748
noahfalk
force-pushed
the
metrics_reference
branch
from
57e96f7 to
febc02f
Compare
tarekgh
reviewed
Sep 22, 2023
tarekgh
reviewed
Sep 22, 2023
tarekgh
reviewed
Sep 22, 2023
tarekgh
approved these changes
Sep 22, 2023
JamesNK
reviewed
Sep 23, 2023
|
Thanks for feedback so far! I added the remaining ASP.NET metrics, updated for feedback, and hopefully caught some of the editing issues. |
antonfirsov
requested changes
Oct 9, 2023
Co-authored-by: Anton Firszov <[email protected]>
antonfirsov
approved these changes
Oct 10, 2023
If the dotnet doc folks can't do this, @tdykstra and I can help. See open-telemetry/semantic-conventions#283 where @tdykstra and I have made massive edits. |
Done :) |
5 tasks
antonfirsov
added a commit
that referenced
this pull request
Dec 10, 2024
.NET 9 introduced additions to `System.Net` distributed tracing which define a contract following OTel recommendations: - dotnet/runtime#104251 adjusted the HTTP client request activity so it natively complies with OTel recommendations. This included adding standard tags. - dotnet/runtime#103922 introduced activities breaking down the HTTP connection setup. This PR documents the activities together with their attributes in a manner similar to the metrics docs added by #37213. The matching semconv PR is open-telemetry/semantic-conventions#1192. Conceptual docs are being introduced in #42830. Moreover, the PR also adjusts certain parts of the metrics doc in order to make it more accurate, synchronize it with the activities doc and incorporate the changes from #42810. --------- Co-authored-by: Genevieve Warren <[email protected]> Co-authored-by: Miha Zupan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #36748
This is part of new metrics reference material. If the patterns look good I can add the rest, but also happy to shuffle things around. For now I put all the metrics into files within the diagnostics folder, but I can move them anywhere area owners would like them to be. In the future I imagine adding more pages for runtime metrics, Microsoft.Extensions metrics, EF metrics, and potentially any other area of the runtime that adds metrics. The overview admittedly feels a little spartan for now.
@JamesNK @antonfirsov @tarekgh @samsp-msft
Internal previews