Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document NET 7 breaking changes for workloads and RID inference #32784

Closed
wants to merge 2 commits into from
Closed

Document NET 7 breaking changes for workloads and RID inference #32784

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcc3115
Document breaking changes for workloads and RID inference
nagilson Nov 29, 2022
070c28a
Respond to linter feedback for whitespace
nagilson Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/core/compatibility/7.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,8 @@ If you're migrating an app to .NET 7, the breaking changes listed here might aff
| [MSBuild serialization of custom types in .NET 7](sdk/7.0/custom-serialization.md) | ❌ | ❌ | 7.0.100 |
| [dotnet test: switch `-a` to alias `--arch` instead of `--test-adapter-path`](https://github.com/dotnet/sdk/issues/21389) | ❌ | ❌ | Preview 1 |
| [dotnet test: switch `-r` to alias `--runtime` instead of `--results-dir`](https://github.com/dotnet/sdk/issues/21952) | ❌ | ❌ | Preview 1 |
| [Preview .NET 7 SDK installation workloads can interfere with RTM workloads](https://github.com/dotnet/core/blob/main/release-notes/7.0/known-issues.md#70-projects-using-certain-workloads-dont-load-build-and-or-run-if-net-7-preview-sdk-workloads-are-installed) |✔️ | ✔️ | Preview 3 |
Copy link
Contributor

@gewarren gewarren Nov 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PriyaPurkayastha Can you take a look at this pattern of just including the breaking change in the overview doc for breaking changes and then linking to a dotnet/sdk or dotnet/core issue for the details?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, I just noticed at the same time that previously in net 6 there were individual doc pages for each change. That seems better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nagilson The established process for .NET breaking changes is to open an issue using the breaking change issue template, and then someone from the docs team (me) transcribes that into a doc: https://github.com/dotnet/docs/issues/new?assignees=gewarren&labels=breaking-change%2CPri1%2Cdoc-idea&template=breaking-change.yml&title=%5BBreaking+change%5D%3A+

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing me to that. I can go fill that out... there is another breaking change we will likely make in 7.0.200 as well, anywho

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will close this since there are now 2 issues filled out using the template. As for the other breaking change, it hasn't been merged yet, and we may be able to circumvent it, so I won't make that one for now.

| [Runtime Identifiers are now automatically inferred and added for `SelfContained`, `PublishSingleFile`, `PublishReadyToRun`, `PublishAot`](https://github.com/dotnet/sdk/issues/26028) | ❌ | ✔️ | RC 1 |

## Serialization

Expand Down