Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

embedded nulls cause issues with event payload #31022

Merged
merged 3 commits into from
Sep 7, 2022
Merged

embedded nulls cause issues with event payload #31022

merged 3 commits into from
Sep 7, 2022

Conversation

mikelle-rogers
Copy link
Member

decoding.

Adding notes regarding how embedded nulls cause issues with event payload decoding.
Fixes 52025

@dotnet-bot dotnet-bot added this to the September 2022 milestone Sep 6, 2022
tommcdon
tommcdon approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@tommcdon tommcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@mikelle-rogers mikelle-rogers marked this pull request as ready for review September 7, 2022 21:52
@mikelle-rogers mikelle-rogers requested a review from a team as a code owner September 7, 2022 21:52
@mikelle-rogers mikelle-rogers merged commit dcc4bea into main Sep 7, 2022
@mikelle-rogers mikelle-rogers deleted the dev/mirogers/embedded_nulls branch September 7, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davmason davmason davmason left review comments

@tommcdon tommcdon tommcdon approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
September 2022
Development

Successfully merging this pull request may close these issues.

Strings with embedded nulls cause issues with event payload decoding
4 participants
@mikelle-rogers @davmason @tommcdon @dotnet-bot