Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref fields and scoped. Modify pages on struct creation, variable declaration, and ref struct. #30912

Merged
merged 16 commits into from
Sep 20, 2022

Conversation

BillWagner
Copy link
Member

@BillWagner BillWagner commented Aug 29, 2022

Fixes #30226

#30226 (comment) describes the tasks in this PR. The commits follow the task list.

Internal review site:

Changes in other files are primarily updating links and link text.

Note for reviewers: The articles tagged above have the significant changes. Samples moved to the updated folders. Almost all other article changes were updating links to updated content for the language reference.

@dotnet-bot dotnet-bot added this to the August 2022 milestone Aug 29, 2022
@BillWagner BillWagner force-pushed the ref-fields-and-scoped branch 3 times, most recently from 4b192d6 to 1f86add Compare August 31, 2022 15:07
@BillWagner BillWagner modified the milestones: August 2022, September 2022 Sep 6, 2022
@BillWagner BillWagner force-pushed the ref-fields-and-scoped branch 5 times, most recently from a9de4e8 to e2c87c4 Compare September 12, 2022 14:11
@BillWagner BillWagner force-pushed the ref-fields-and-scoped branch 2 times, most recently from e90bee5 to 2af2dbd Compare September 14, 2022 22:17
@BillWagner BillWagner marked this pull request as ready for review September 15, 2022 19:14
@BillWagner BillWagner force-pushed the ref-fields-and-scoped branch from cac1ec8 to 889bb23 Compare September 15, 2022 19:22
@BillWagner BillWagner added okr-freshness OKR: Freshness of content okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. labels Sep 15, 2022
@BillWagner BillWagner requested a review from jaredpar September 16, 2022 14:15
@BillWagner
Copy link
Member Author

@Youssef1313 Is there a tag for the F1 help for scoped? I'll add it to this PR.

Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, well done. I had a few nits, questions, and suggestions.

docs/csharp/language-reference/builtin-types/ref-struct.md Outdated Show resolved Hide resolved
docs/csharp/language-reference/builtin-types/ref-struct.md Outdated Show resolved Hide resolved
docs/csharp/language-reference/builtin-types/ref-struct.md Outdated Show resolved Hide resolved
docs/csharp/language-reference/builtin-types/ref-struct.md Outdated Show resolved Hide resolved
docs/csharp/language-reference/builtin-types/struct.md Outdated Show resolved Hide resolved
docs/csharp/language-reference/statements/declarations.md Outdated Show resolved Hide resolved
docs/csharp/language-reference/statements/declarations.md Outdated Show resolved Hide resolved
docs/csharp/language-reference/statements/declarations.md Outdated Show resolved Hide resolved
@Youssef1313
Copy link
Member

Youssef1313 commented Sep 16, 2022

@Youssef1313 Is there a tag for the F1 help for scoped? I'll add it to this PR.

I'm not sure. I added a test in dotnet/roslyn#64094 and will see what CI says :)
It most likely will be scoped_CSharpKeyword as most other keywords.

Update all links to sections that have moved.
Move the pass by reference and pass by value sections of the programming guide to the C# language reference.
Update samples, provide better definition for passing
reference parameters and value parameters by reference
or by value.
BillWagner and others added 13 commits September 20, 2022 10:08
Not happy with them yet, but there's it's a start.
- Move `var` article to form the core of the new "Declaration statements" article.
- Add content from Programming guide article on "ref returns and ref locals" to new declaration article.
- Add content from Prog Guide article on "ref returns" (same article) to the section on `return` in the Jump statements article.
Move all samples from the /samples/snippets folder under the current folder.
Define value assignment and ref assignment.
The scoped modifier limits the lifetime of the modified variable
namespace name changes
@BillWagner BillWagner force-pushed the ref-fields-and-scoped branch from d3aeb0b to b7da93f Compare September 20, 2022 14:09
@BillWagner
Copy link
Member Author

closing and reopening for a fresh build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[17.3] ref fields and scoped
5 participants