Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup trimming options and document TrimMode=full,partial #30279

Merged
merged 19 commits into from
Aug 5, 2022

Conversation

agocke
Copy link
Member

@agocke agocke commented Jul 19, 2022

@agocke
Copy link
Member Author

agocke commented Jul 22, 2022

Right now I'm fighting some infra fires and am not sure when I'll be able to rewrite the article to use the "trimmable" terminology. Do we want to take this as-is and have that be a second PR?

Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more minor comments but LGTM. Thank you!

@gewarren
Copy link
Contributor

We'll also need to update the options summary here: https://docs.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#trim-related-properties.

@agocke
Copy link
Member Author

agocke commented Aug 3, 2022

@gewarren Anything else? I presume we want to merge this ASAP so that people who see the breaking change notice have more details about workarounds.

@gewarren
Copy link
Contributor

gewarren commented Aug 3, 2022

@gewarren Anything else? I presume we want to merge this ASAP so that people who see the breaking change notice have more details about workarounds.

We'll also need to update the options summary here: https://docs.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#trim-related-properties. But I can do that in a separate PR if you like.

@agocke
Copy link
Member Author

agocke commented Aug 3, 2022

Done, thanks

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@agocke agocke enabled auto-merge (squash) August 5, 2022 04:57
@agocke agocke merged commit 526d0cd into dotnet:main Aug 5, 2022
@gewarren gewarren added the 🏁 Release: .NET 7 Work items for the .NET 7 release label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏁 Release: .NET 7 Work items for the .NET 7 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants