Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about OOM on gcdump #29248

Merged
merged 2 commits into from
May 2, 2022
Merged

Add note about OOM on gcdump #29248

merged 2 commits into from
May 2, 2022

Conversation

josalem
Copy link
Contributor

@josalem josalem commented May 2, 2022

@josalem josalem requested a review from noahfalk May 2, 2022 18:11
@josalem josalem self-assigned this May 2, 2022
@josalem josalem requested review from tommcdon and a team as code owners May 2, 2022 18:11
noahfalk
noahfalk approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/core/diagnostics/dotnet-gcdump.md Outdated Show resolved Hide resolved
@josalem josalem merged commit cf02e97 into dotnet:main May 2, 2022
@josalem josalem deleted the dev/josalem/dotnet-gcdump-mem-usage branch May 2, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

@noahfalk noahfalk noahfalk approved these changes

@tommcdon tommcdon Awaiting requested review from tommcdon tommcdon is a code owner

Assignees

@josalem josalem

Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dotnet-gcdump collect causes OutOfMemoryException
4 participants
@josalem @noahfalk @gewarren @dotnet-bot