Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflection invoke exceptions #29228

Merged
merged 3 commits into from
Jul 8, 2022
Merged

Reflection invoke exceptions #29228

merged 3 commits into from
Jul 8, 2022

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Apr 29, 2022 •
edited
Loading

Fixes #29199

gewarren
gewarren commented Apr 29, 2022
View reviewed changes
Copy link
Contributor Author

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steveharter Can you take a look at my questions? This one was hard for me to wrap my head around :)

@gewarren gewarren requested review from steveharter and a team April 29, 2022 23:36
@gewarren
Copy link
Contributor Author

Ping @steveharter.

@dotnet-bot dotnet-bot added this to the June 2022 milestone Jun 3, 2022
@gewarren gewarren merged commit 2fa553b into dotnet:main Jul 8, 2022
@gewarren gewarren deleted the refl-exceptions branch July 8, 2022 17:18
@gewarren
Copy link
Contributor Author

gewarren commented Jul 8, 2022

Thanks @IEvangelist!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IEvangelist IEvangelist IEvangelist approved these changes

@steveharter steveharter Awaiting requested review from steveharter

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
June 2022
Development

Successfully merging this pull request may close these issues.

[Breaking change]: exceptions thrown by reflection Invoke() APIs have changed
4 participants
@gewarren @IEvangelist @BillWagner @dotnet-bot