Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete HostWithMscoree sample #20608

Merged
merged 3 commits into from
Sep 24, 2020
Merged

Delete HostWithMscoree sample #20608

merged 3 commits into from
Sep 24, 2020

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Sep 12, 2020

Summary

Mscoree is legacy API with a lot of unsupported functionality from Silverlight times. Pointing people to it creates confusion.

Addressed feedback from dotnet/runtime#39167

Mscoree is legacy API with a lot of unsupported functionality from Silverlight times. Pointing people to it creates confusion.
@jkotas
Copy link
Member Author

jkotas commented Sep 12, 2020

Related dotnet/samples#3886

Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we'll :shipit: - thank you 🙏

@jkotas jkotas merged commit a3c6213 into dotnet:master Sep 24, 2020
@jkotas jkotas deleted the mscoree-host branch September 24, 2020 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants