Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet test CLI ref updates #18209

Merged
merged 5 commits into from
May 26, 2020
Merged

dotnet test CLI ref updates #18209

merged 5 commits into from
May 26, 2020

Conversation

tdykstra
Copy link
Contributor

@tdykstra tdykstra commented May 1, 2020 •
edited
Loading

Fixes #17256
Fixes #17135

@dotnet-bot dotnet-bot added this to the May 2020 milestone May 1, 2020
@tdykstra tdykstra requested a review from kendrahavens May 1, 2020 19:42
@tdykstra tdykstra changed the title Add code coverage to dotnet test CLI ref dotnet test CLI ref updates May 1, 2020
@tdykstra tdykstra requested review from nohwnd and removed request for kendrahavens May 7, 2020 20:38
@tdykstra
Copy link
Contributor Author

@nohwnd please review

@nohwnd
Copy link
Member

nohwnd commented May 21, 2020

@tdykstra @jakubch1 would be a better person to review this, because he is focusing on code coverage.

@jakubch1 please review this.

@tdykstra
Copy link
Contributor Author

@jakubch1 @nohwnd Thanks for review!

@tdykstra tdykstra requested a review from BillWagner May 21, 2020 15:21
BillWagner
BillWagner approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @tdykstra

You can :shipit: when ready.

@tdykstra tdykstra merged commit 7a64cd9 into dotnet:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubch1 jakubch1 jakubch1 approved these changes

@BillWagner BillWagner BillWagner approved these changes

@nohwnd nohwnd Awaiting requested review from nohwnd

Assignees
No one assigned
Labels
cli/subsvc
Projects
None yet
Milestone
May 2020
Development

Successfully merging this pull request may close these issues.

The --collect option should include code coverage example NUnit filter example is not covered
5 participants
@tdykstra @nohwnd @BillWagner @jakubch1 @dotnet-bot