Update packaging guidelines cont #14339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagood
approved these changes
Sep 10, 2019
tmds
commented
Sep 11, 2019
leecow
reviewed
Sep 11, 2019
…red between packages
omajid
reviewed
Sep 13, 2019
…rd-targeting-pack
dagood
approved these changes
Sep 16, 2019
| @@ -171,6 +171,8 @@ Most distributions require all artifacts to be built from source. This has some | |||
|
|
|||
| Multiple `dotnet-sdk` packages may provide the same files for the `NuGetFallbackFolder`. To avoid issues with the package manager, these files should be identical (checksum, modification date, and so on). | |||
|
|
|||
| The folders marked with `(*)` are used by multiple packages. Some package formats (e.g. `rpm`) require special handling of such folders. The package maintainer must take care of this. | |||
There was a problem hiding this comment.
I think this should be at the end of the Disk layout section instead, had a hard time finding it so far away from the table.
| @@ -171,6 +171,8 @@ Most distributions require all artifacts to be built from source. This has some | |||
|
|
|||
| Multiple `dotnet-sdk` packages may provide the same files for the `NuGetFallbackFolder`. To avoid issues with the package manager, these files should be identical (checksum, modification date, and so on). | |||
|
|
|||
| The folders marked with `(*)` are used by multiple packages. Some package formats (e.g. `rpm`) require special handling of such folders. The package maintainer must take care of this. | |||
There was a problem hiding this comment.
It would be nice to have this described somewhere... but this note LGTM--hard to make it clear to readers not already familiar with this requirement without putting a lot more info in this doc and probably cluttering it up. Selfishly, I'd like to get the Microsoft RPMs up to snuff, and know what the consequences are of getting it wrong.
There was a problem hiding this comment.
Yes, we can assume that the package maintainer knows what this is about.
|
I've applied the suggestions so we can get this merged. Thanks so much @tmds! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses comments #13196 (comment) and below.
@omajid @dagood ptal
cc @leecow